vvysotskyi commented on a change in pull request #1527: DRILL-4456: Fix Hive
translate UDF
URL: https://github.com/apache/drill/pull/1527#discussion_r231975877
##########
File path:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/expr/fn/HiveFunctionRegistry.java
##########
@@ -48,8 +52,17 @@
import
org.apache.drill.shaded.guava.com.google.common.collect.ArrayListMultimap;
import org.apache.drill.shaded.guava.com.google.common.collect.Sets;
-public class HiveFunctionRegistry implements PluggableFunctionRegistry{
- static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(HiveFunctionRegistry.class);
+public class HiveFunctionRegistry implements PluggableFunctionRegistry {
+ private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(HiveFunctionRegistry.class);
+
+ /**
+ * Map for renaming Hive UDFs whose names satisfy the predicate in the key
by names from the map value.
+ */
+ private static final Map<Predicate<String[]>, String[]> FUNCTION_REPLACE_MAP
= ImmutableMap.<Predicate<String[]>, String[]> builder()
Review comment:
Thanks, reworded a description and simplified the map to use target function
names as keys and predicates for checking as values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
