vvysotskyi commented on a change in pull request #1528: DRILL-3610: Add
TIMESTAMPADD and TIMESTAMPDIFF functions
URL: https://github.com/apache/drill/pull/1528#discussion_r232337509
##########
File path:
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/IntervalNumericArithmetic.java
##########
@@ -129,20 +129,22 @@ public void eval() {
}
}
- @SuppressWarnings("unused")
- @FunctionTemplate(names = {"divide", "div"}, scope =
FunctionTemplate.FunctionScope.SIMPLE, nulls=NullHandling.NULL_IF_NULL)
- public static class ${intervaltype}${numerictype}DivideFunction implements
DrillSimpleFunc {
+ @SuppressWarnings("unused")
+ @FunctionTemplate(names = {"divide", "div"<#if numerictype == "Int">,
"/int"</#if>},
+ scope = FunctionTemplate.FunctionScope.SIMPLE,
+ nulls = NullHandling.NULL_IF_NULL)
+ public static class ${intervaltype}${numerictype}DivideFunction implements
DrillSimpleFunc {
@Param ${intervaltype}Holder left;
@Param ${numerictype}Holder right;
@Output IntervalHolder out;
- public void setup() {
- }
+ public void setup() {
+ }
- public void eval() {
- <@intervalNumericArithmeticBlock left="left" right="right" temp =
"temp" op = "/" out = "out" intervaltype=intervaltype />
- }
+ public void eval() {
+ <@intervalNumericArithmeticBlock left="left" right="right" temp = "temp"
op = "/" out = "out" intervaltype=intervaltype />
}
+ }
}
</#list>
</#list>
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
