sohami commented on a change in pull request #1504: DRILL-6792: Find the right
probe side fragment wrapper & fix DrillBuf…
URL: https://github.com/apache/drill/pull/1504#discussion_r232866925
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContextImpl.java
##########
@@ -136,8 +143,8 @@ public void interrupt(final InterruptedException e) {
private final AccountingUserConnection accountingUserConnection;
/** Stores constants and their holders by type */
private final Map<String, Map<MinorType, ValueHolder>>
constantValueHolderCache;
-
- private RuntimeFilterSink runtimeFilterSink;
+ private Map<Long, RuntimeFilterWritable> rfIdentifier2RFW = new
ConcurrentHashMap<>();
+ private Map<Long, Boolean> rfIdentifier2fetched = new ConcurrentHashMap<>();
Review comment:
The information which `rfIdentifier2fetched` map is storing can be
implicitly derived using first map `rfIdentifier2RFW`. Once the
`RuntimeFilterWritable` is consumed just remove it from first map. Then in
`closeReceivedRFWs` just call `close` on the `RuntimeFilterWritable` which is
present.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
