vvysotskyi commented on a change in pull request #1537: DRILL-6744: Support
varchar and decimal push down
URL: https://github.com/apache/drill/pull/1537#discussion_r233132202
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/stat/ParquetMetaStatCollector.java
##########
@@ -86,30 +87,26 @@ public ParquetMetaStatCollector(ParquetTableMetadataBase
parquetTableMetadata,
columnMetadataMap.put(schemaPath, columnMetadata);
}
- for (final SchemaPath field : fields) {
- final PrimitiveType.PrimitiveTypeName primitiveType;
- final OriginalType originalType;
-
- final ColumnMetadata columnMetadata =
columnMetadataMap.get(field.getUnIndexed());
-
+ for (SchemaPath field : fields) {
+ ColumnMetadata columnMetadata =
columnMetadataMap.get(field.getUnIndexed());
if (columnMetadata != null) {
- final Object min = columnMetadata.getMinValue();
- final Object max = columnMetadata.getMaxValue();
- final long numNulls = columnMetadata.getNulls() == null ? -1 :
columnMetadata.getNulls();
-
- primitiveType =
this.parquetTableMetadata.getPrimitiveType(columnMetadata.getName());
- originalType =
this.parquetTableMetadata.getOriginalType(columnMetadata.getName());
- int precision = 0;
- int scale = 0;
+ ColumnStatisticsBuilder statisticsBuilder =
ColumnStatisticsBuilder.builder()
+ .setMin(columnMetadata.getMinValue())
+ .setMax(columnMetadata.getMaxValue())
+ .setNumNulls(columnMetadata.getNulls() == null ? -1 :
columnMetadata.getNulls())
Review comment:
Please replace -1 with `GroupScan.NO_COLUMN_STATS`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
