kkhatua commented on a change in pull request #1536: DRILL-6039: Fixed 
drillbit.sh script to do graceful shutdown
URL: https://github.com/apache/drill/pull/1536#discussion_r235140653
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/Drillbit.java
 ##########
 @@ -285,6 +286,10 @@ public synchronized void close() {
       if (storeProvider != profileStoreProvider) {
         AutoCloseables.close(profileStoreProvider);
       }
+      File f = new File(System.getenv("DRILL_PID_DIR") + "/.graceful");
 
 Review comment:
   You could provide this as an env var (full path: 
`DRILL_PID_DIR+"/"+GRACEFUL_SIGFILE`) within the `drill-config.sh` (ref: 
https://github.com/apache/drill/blob/master/distribution/src/resources/drill-config.sh#L336
 )
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to