vvysotskyi commented on a change in pull request #1552: DRILL-6865: Query
returns wrong result when filter pruning happens
URL: https://github.com/apache/drill/pull/1552#discussion_r235997768
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFilterBuilder.java
##########
@@ -71,18 +72,24 @@
*
* @return parquet filter predicate
*/
- public static ParquetFilterPredicate
buildParquetFilterPredicate(LogicalExpression expr, final
Set<LogicalExpression> constantBoundaries, UdfUtilities udfUtilities) {
- LogicalExpression logicalExpression = expr.accept(new
ParquetFilterBuilder(udfUtilities), constantBoundaries);
+ public static ParquetFilterPredicate
buildParquetFilterPredicate(LogicalExpression expr,
+ Set<LogicalExpression> constantBoundaries, UdfUtilities udfUtilities,
boolean omitUnsupportedExprs) {
+ LogicalExpression logicalExpression =
+ expr.accept(new ParquetFilterBuilder(udfUtilities,
omitUnsupportedExprs), constantBoundaries);
if (logicalExpression instanceof ParquetFilterPredicate) {
return (ParquetFilterPredicate) logicalExpression;
+ } else if (logicalExpression instanceof TypedFieldExpr) {
+ // Calcite simplifies `= true` expression to field name, wrap it with is
true predicate
+ return (ParquetFilterPredicate)
ParquetIsPredicate.createIsPredicate(FunctionGenerationHelper.IS_TRUE,
logicalExpression);
Review comment:
This change was added because now we try to convert every expression,
especially arguments of `AND` operator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
