sohami commented on a change in pull request #1504: DRILL-6792: Find the right probe side fragment wrapper & fix DrillBuf… URL: https://github.com/apache/drill/pull/1504#discussion_r236397662
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/RuntimeFilterSink.java ########## @@ -40,23 +41,18 @@ import java.util.concurrent.BlockingQueue; import java.util.concurrent.LinkedBlockingQueue; import java.util.concurrent.TimeUnit; -import java.util.concurrent.locks.Condition; -import java.util.concurrent.locks.ReentrantLock; +import java.util.concurrent.atomic.AtomicBoolean; /** * This sink receives the RuntimeFilters from the netty thread, * aggregates them in an async thread, broadcast the final aggregated * one to the RuntimeFilterRecordBatch. */ -public class RuntimeFilterSink +public class RuntimeFilterSink implements Cloneable Review comment: implements `Closeable`. Also there are race condition similar to ones pointed out in original implementation of this class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
