gparai opened a new pull request #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin URL: https://github.com/apache/drill/pull/1568 @amansinha100 can you please review the PR? Thanks! With the fix, I see the following wrong results which would be fixed in a separate JIRA. I can disable them as well. IndexPlanTest.testCastTimestampPlan IndexPlanTest.testRowkeyJoinPushdown_1 IndexPlanTest.testRowkeyJoinPushdown_10 IndexPlanTest.testRowkeyJoinPushdown_13 IndexPlanTest.testRowkeyJoinPushdown_6 IndexPlanTest.testRowkeyJoinPushdown_7 IndexPlanTest.testRowkeyJoinPushdown_9 IndexPlanTest.testNoFilterGroupByHashIndex IndexPlanTest.testNoFilterOrderByHashIndex testRowkeyJoinPushdown_12 is disabled because we no longer get the desired pattern after semi-join kicks-in. The join order changes making it illegal to apply the transformation. Hence, we do not generate a rowkeyjoin so I disabled this positive testcase.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
