[GitHub] amansinha100 commented on a change in pull request #1568: DRILL-6878: Use DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for DrillSemiJoin

[GitBox]

amansinha100 commented on a change in pull request #1568: DRILL-6878: Use 
DrillPushRowKeyJoinToScan rule on DrillJoin pattern to o account for 
DrillSemiJoin
URL: https://github.com/apache/drill/pull/1568#discussion_r240485180
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillJoinRel.java
 ##########
 @@ -55,53 +53,33 @@
   private int joinControl = JoinControl.DEFAULT;
 
   public DrillJoinRel(RelOptCluster cluster, RelTraitSet traits, RelNode left, 
RelNode right, RexNode condition,
-                      JoinRelType joinType) {
-    this(cluster, traits, left, right, condition, joinType, false);
-  }
-
-  public DrillJoinRel(RelOptCluster cluster, RelTraitSet traits, RelNode left, 
RelNode right, RexNode condition,
-      JoinRelType joinType, boolean isSemiJoin) {
+      JoinRelType joinType) {
     super(cluster, traits, left, right, condition, joinType);
     assert traits.contains(DrillRel.DRILL_LOGICAL);
     RelOptUtil.splitJoinCondition(left, right, condition, leftKeys, rightKeys, 
filterNulls);
-    this.isSemiJoin = isSemiJoin;
   }
 
   public DrillJoinRel(RelOptCluster cluster, RelTraitSet traits, RelNode left, 
RelNode right, RexNode condition,
       JoinRelType joinType, int joinControl)  {
-    this(cluster, traits, left, right, condition, joinType, joinControl, 
false);
-  }
-
-  public DrillJoinRel(RelOptCluster cluster, RelTraitSet traits, RelNode left, 
RelNode right, RexNode condition,
-                      JoinRelType joinType, int joinControl, boolean 
isSemiJoin)  {
     super(cluster, traits, left, right, condition, joinType);
     assert traits.contains(DrillRel.DRILL_LOGICAL);
     RelOptUtil.splitJoinCondition(left, right, condition, leftKeys, rightKeys, 
filterNulls);
     this.joinControl = joinControl;
-    this.isSemiJoin = isSemiJoin;
   }
 
   public DrillJoinRel(RelOptCluster cluster, RelTraitSet traits, RelNode left, 
RelNode right, RexNode condition,
       JoinRelType joinType, List<Integer> leftKeys, List<Integer> rightKeys) 
throws InvalidRelException {
-    this(cluster, traits, left, right, condition, joinType, leftKeys, 
rightKeys, false);
-  }
-
-  public DrillJoinRel(RelOptCluster cluster, RelTraitSet traits, RelNode left, 
RelNode right, RexNode condition,
-      JoinRelType joinType, List<Integer> leftKeys, List<Integer> rightKeys, 
boolean isSemiJoin)
-      throws InvalidRelException {
     super(cluster, traits, left, right, condition, joinType);
     assert traits.contains(DrillRel.DRILL_LOGICAL);
 
     assert (leftKeys != null && rightKeys != null);
     this.leftKeys = leftKeys;
     this.rightKeys = rightKeys;
-    this.isSemiJoin = isSemiJoin;
   }
 
   @Override
-  public DrillJoinRel copy(RelTraitSet traitSet, RexNode condition, RelNode 
left, RelNode right, JoinRelType joinType,
-      boolean semiJoinDone) {
-    return new DrillJoinRel(getCluster(), traitSet, left, right, condition, 
joinType, semiJoinDone);
+  public DrillJoinRel copy(RelTraitSet traitSet, RexNode condition, RelNode 
left, RelNode right, JoinRelType joinType, boolean semiJoinDone) {
 
 Review comment:
   The copy() method is taking a `semiJoinDone` argument even though it does 
not use it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services