vdiravka commented on a change in pull request #1586: DRILL-6929: Exclude 
maprfs jar for default profile
URL: https://github.com/apache/drill/pull/1586#discussion_r244193372
 
 

 ##########
 File path: contrib/storage-hive/core/pom.xml
 ##########
 @@ -142,11 +142,6 @@
         </exclusion>
       </exclusions>
     </dependency>
-    <dependency>
 
 Review comment:
   To follow excluding MapR specific code from the default profile, please move 
`format-maprdb` to `mapr` profile in the contrib/pom.xml
   
   ```
     <modules>
       <module>storage-hbase</module>
       <module>storage-hive</module>
       <module>storage-mongo</module>
       <module>storage-jdbc</module>
       <module>storage-kafka</module>
       <module>storage-kudu</module>
       <module>storage-opentsdb</module>
       <module>data</module>
       <module>udfs</module>
     </modules>
   ```
   
   ```
       <profile>
         <id>mapr</id>
         <modules>
           <module>format-maprdb</module>
         </modules>
       </profile>
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to