sohami commented on a change in pull request #1600: DRILL-6947: fix
RuntimeFilter memory leak
URL: https://github.com/apache/drill/pull/1600#discussion_r249937518
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -819,7 +820,7 @@ private void initializeBuild() {
}
private void initializeRuntimeFilter() {
- if (!enableRuntimeFilter) {
+ if (!enableRuntimeFilter || bloomFiltersGenerated) {
Review comment:
Good find. Thanks for fixing it.
Also please add a comment that: "This method can be called again as part of
recursive call of `executeBuildPhase()` to handle spilled build partitions"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
