[GitHub] ihuzenko commented on issue #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

[GitBox]

ihuzenko commented on issue #1608: DRILL-6960: Auto Limit Wrapping should not 
apply to non-select query
URL: https://github.com/apache/drill/pull/1608#issuecomment-458137436
 
 
     Hello @kkhatua , sorry for the late answer. I wanted to start review from 
check that fix works fine, but suddenly bumped into an issue. I wasn't able to 
submit query with my current locale, because it affects number formatting. 
   
      1. Tried to use default number: 
   
![drill-6960_1](https://user-images.githubusercontent.com/4282630/51839839-0f539f00-2313-11e9-9e22-689d213a4a91.png)
   
      2. Tried to remove comma from default number: 
   
![drill-6960_2](https://user-images.githubusercontent.com/4282630/51840010-8ee16e00-2313-11e9-9bb6-b6b26f52c1e3.png)
   
      3. Tried to use own auto limit 50 :
   
![drill-6960_3](https://user-images.githubusercontent.com/4282630/51840016-9143c800-2313-11e9-9ab3-3d1e35bd1b16.png)
   
      After those failed attempts I executed the line 
```console.log(window.navigator.userLanguage || window.navigator.language)``` 
in JS console and got locale ```en-US``` in my chromium-browser. 
   
      @kkhatua, can you please fix the blocking issue in order to unlock 
further review ? Thank you in advance, Igor. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services