[GitHub] vvysotskyi commented on a change in pull request #1608: DRILL-6960: Auto Limit Wrapping should not apply to non-select query

[GitBox]

vvysotskyi commented on a change in pull request #1608: DRILL-6960: Auto Limit 
Wrapping should not apply to non-select query
URL: https://github.com/apache/drill/pull/1608#discussion_r253814230
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
 ##########
 @@ -136,15 +136,30 @@
    */
   public Foreman(final WorkerBee bee, final DrillbitContext drillbitContext,
       final UserClientConnection connection, final QueryId queryId, final 
RunQuery queryRequest) {
+    this(bee, drillbitContext, connection, queryId, queryRequest, null);
+  }
+
+  /**
+   * Constructor. Sets up the Foreman, but does not initiate any execution.
+   *
+   * @param bee work manager (runs fragments)
+   * @param drillbitContext drillbit context
+   * @param connection connection
+   * @param queryId the id for the query
+   * @param queryRequest the query to execute
+   * @param autoLimitRowCount the number of rows to limit in execution (used 
for WebRequests)
+   */
+  public Foreman(final WorkerBee bee, final DrillbitContext drillbitContext,
 
 Review comment:
   I'm not sure that changing `Foreman` constructor signature or adding the new 
one is a good idea. Can `autoLimitRowCount` be set into `RunQuery` object and 
then obtained where needed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services