vvysotskyi commented on issue #1608: DRILL-6960: Auto Limit Wrapping should not 
apply to non-select query
URL: https://github.com/apache/drill/pull/1608#issuecomment-460669449
 
 
   Regarding this fix and fix for DRILL-6050. I think allowing web-client to 
rewrite the query is not the best approach. A user may want to submit the query 
to see its profile for example, but with this feature, the profile will not 
correspond to the original query. Besides that, this fix does a lot of changes 
for web client on the server side.
   
   It would be better to address this issue by limiting rows which should be 
obtained from the result set on the client side (see 
[WebUserConnection.sendData()](https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebUserConnection.java#L138)
 method).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to