kkhatua commented on a change in pull request #1608: DRILL-6960: Auto Limit
Wrapping should not apply to non-select query
URL: https://github.com/apache/drill/pull/1608#discussion_r254105360
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java
##########
@@ -273,6 +279,29 @@ public RemoteFunctionRegistry getRemoteFunctionRegistry()
{
return drillbitContext.getRemoteFunctionRegistry();
}
+ /**
+ * Check if auto-limiting of resultset is enabled
+ * @return True if auto-limit is enabled
+ */
+ public boolean isAutoLimitEnabled() {
+ return autoLimitRowCount != null;
+ }
+
+ /**
+ * Returns the maximum size of auto-limited resultset
+ * @return Maximum size of auto-limited resultSet
+ */
+ public Integer getAutoLimitRowCount() {
Review comment:
The feature is specifically for WebUI submitted queries. A query option
doesn't make sense because WebUI queries are "session-less" and the only reason
we want to wrap with a limit is to prevent the Drillbit from being overloaded
with holding an entire result set that does not get completely consumed by the
HTTP client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
