ihuzenko commented on a change in pull request #1608: DRILL-6960: AutoLimit the
size of ResultSet for a WebUI (or REST) client
URL: https://github.com/apache/drill/pull/1608#discussion_r257198998
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java
##########
@@ -84,9 +85,14 @@
private boolean closed = false;
private DrillOperatorTable table;
- public QueryContext(final UserSession session, final DrillbitContext
drillbitContext, QueryId queryId) {
+ public QueryContext(final UserSession session, final DrillbitContext
drillbitContext, final QueryId queryId) {
+ this(session, drillbitContext, queryId, null);
+ }
+
+ public QueryContext(final UserSession session, final DrillbitContext
drillbitContext, final QueryId queryId, final Integer autoLimit) {
this.drillbitContext = drillbitContext;
this.session = session;
+ this.autoLimitRowCount = autoLimit;
Review comment:
In some places the integer named ```autoLimitRowCount``` in other places
```autoLimit``` . It would be more conventional to choose one final name and
use the same name in all files where it's present.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
