[GitHub] Ben-Zvi commented on a change in pull request #1662: DRILL-6825: apply different hash algorithms to different data types

[GitBox]

Ben-Zvi commented on a change in pull request #1662: DRILL-6825: apply 
different hash algorithms to different data types
URL: https://github.com/apache/drill/pull/1662#discussion_r261074977
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/ChainedHashTable.java
 ##########
 @@ -43,11 +41,9 @@
 import org.apache.drill.exec.memory.BufferAllocator;
 import org.apache.drill.exec.ops.FragmentContext;
 import org.apache.drill.exec.physical.impl.join.JoinUtils;
-import org.apache.drill.exec.planner.physical.HashPrelUtil;
 import org.apache.drill.exec.record.MaterializedField;
 import org.apache.drill.exec.record.RecordBatch;
 import org.apache.drill.exec.record.TypedFieldId;
-import org.apache.drill.exec.record.VectorAccessible;
 import org.apache.drill.exec.record.VectorContainer;
 import org.apache.drill.exec.vector.ValueVector;
 
 
 Review comment:
   (This comment should be at lines 71-77 below; github does not let putting a 
comment there....)
   Need also to remove the code generation for "getHashBuild" and 
"getHashProbe".
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services