KazydubB commented on a change in pull request #1671: DRILL-7045 UDF
string_binary java.lang.IndexOutOfBoundsException
URL: https://github.com/apache/drill/pull/1671#discussion_r262869558
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestJsonNanInf.java
##########
@@ -236,6 +236,22 @@ public void testConvertFromJsonFunction() throws
Exception {
+ @Test
+ public void testLargeStringBinary() throws Exception {
+ String chunk = "0123456789";
+ String data = "";
+ for (int i = 0; i < 1000; i++) {
+ data += chunk;
Review comment:
It is preferable to change such string concatenations with
`StringBuilder#append(String)`. (`String data` --> `StringBuilder data`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
