amansinha100 commented on issue #1666: DRILL-7058: Refresh command to support subset of columns URL: https://github.com/apache/drill/pull/1666#issuecomment-470412355 The type of unit tests that depend on the structure of the JSON cache file could be problematic to maintain. We do expect the nature of the metadata stored in the cache file to change/evolve depending on the requirements. Hence, wherever appropriate we should use metrics that are invariants such that in future unit tests don't need to be updated frequently. For example, in TestParquetMetadataCache.java, we use the flag **usedMetadataFile = true/false** for testing. The structure of the cache file was not analyzed there. Can we define additional metrics that are likely to remain invariant but are able to exercise the 'subset-of-coulumns' functionality ?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
