kkhatua commented on a change in pull request #1692: DRILL-6562: Plugin
Management improvements
URL: https://github.com/apache/drill/pull/1692#discussion_r266593874
##########
File path: exec/java-exec/src/main/resources/rest/storage/list.ftl
##########
@@ -17,79 +17,280 @@
limitations under the License.
-->
+
<#include "*/generic.ftl">
<#macro page_head>
+ <script src="/static/js/jquery.form.js"></script>
+
+ <!-- Ace Libraries for Syntax Formatting -->
+ <script src="/static/js/ace-code-editor/ace.js" type="text/javascript"
charset="utf-8"></script>
+ <script src="/static/js/ace-code-editor/theme-eclipse.js"
type="text/javascript" charset="utf-8"></script>
</#macro>
<#macro page_body>
<div class="page-header">
</div>
- <h4>Enabled Storage Plugins</h4>
- <div class="table-responsive">
+
+ <h4 class="col-xs-6">Plugin Management</h4>
+ <table style="margin: 10px" class="table">
+ <tbody>
+ <tr>
+ <td style="border:none;">
+ <button type="button" class="btn btn-primary" data-toggle="modal"
data-target="#new-plugin-modal">
+ Create
+ </button>
+ <button type="button" class="btn btn-primary" name="all"
data-toggle="modal" data-target="#pluginsModal">
+ Export all
+ </button>
+ </td>
+ </tr>
+ </tbody>
+ </table>
+
+ <div class="page-header" style="margin: 5px;"></div>
+
+ <div class="table-responsive col-sm-12 col-md-6 col-lg-5 col-xl-5">
+ <h4>Enabled Storage Plugins</h4>
<table class="table">
<tbody>
<#list model as plugin>
<#if plugin.enabled() == true>
<tr>
- <td style="border:none; width:200px;">
+ <td style="border:none; max-width: 200px; overflow: hidden;
text-overflow: ellipsis;">
${plugin.getName()}
</td>
<td style="border:none;">
- <a class="btn btn-primary"
href="/storage/${plugin.getName()}">Update</a>
- <a class="btn btn-default"
onclick="doEnable('${plugin.getName()}', false)">Disable</a>
- <a class="btn btn-default"
href="/storage/${plugin.getName()}/export"">Export</a>
+ <button type="button" class="btn btn-primary"
onclick="location.href='/storage/${plugin.getName()}'">
+ Update
+ </button>
+ <button type="button" class="btn btn-primary"
onclick="doEnable('${plugin.getName()}', false)">
+ Disable
+ </button>
+ <button type="button" class="btn btn-primary"
name="${plugin.getName()}" data-toggle="modal"
Review comment:
```suggestion
<button type="button" class="btn" name="${plugin.getName()}"
data-toggle="modal"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
