vdiravka commented on a change in pull request #1706: DRILL-7115: Improve Hive
schema show tables performance
URL: https://github.com/apache/drill/pull/1706#discussion_r267904395
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/parser/DrillParserUtil.java
##########
@@ -17,31 +17,31 @@
*/
package org.apache.drill.exec.planner.sql.parser;
+import java.util.ArrayList;
import java.util.List;
import org.apache.calcite.sql.SqlNode;
import org.apache.calcite.sql.SqlOperator;
import org.apache.calcite.sql.parser.SqlParserPos;
import org.apache.calcite.sql.parser.SqlParserUtil;
-import org.apache.calcite.util.Util;
-
-import org.apache.drill.shaded.guava.com.google.common.collect.Lists;
/**
* Helper methods or constants used in parsing a SQL query.
*/
public class DrillParserUtil {
- public static final String CHARSET = Util.getDefaultCharset().name();
+ private static final int CONDITION_LIST_CAPACITY = 3;
public static SqlNode createCondition(SqlNode left, SqlOperator op, SqlNode
right) {
// if one of the operands is null, return the other
- if (left == null || right == null) {
- return left != null ? left : right;
+ if (left == null) {
Review comment:
gj
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
