vdiravka commented on a change in pull request #1706: DRILL-7115: Improve Hive
schema show tables performance
URL: https://github.com/apache/drill/pull/1706#discussion_r267903717
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
##########
@@ -744,16 +744,37 @@ private ExecConstants() {
public static final BooleanValidator
CTAS_PARTITIONING_HASH_DISTRIBUTE_VALIDATOR = new
BooleanValidator(CTAS_PARTITIONING_HASH_DISTRIBUTE,
new OptionDescription("Uses a hash algorithm to distribute data on
partition keys in a CTAS partitioning operation. An alpha option--for
experimental use at this stage. Do not use in production systems."));
+
+ /**
+ * The option added as part of DRILL-4577, was used to mark that hive tables
should be loaded
+ * for all table names at once. Then as part of DRILL-4826 was added option
to regulate bulk size,
+ * because big amount of views was causing performance degradation. After
last improvements for
+ * DRILL-7115 both options ({@link
ExecConstants#ENABLE_BULK_LOAD_TABLE_LIST_KEY}
+ * and {@link ExecConstants#BULK_LOAD_TABLE_LIST_BULK_SIZE_KEY}) became
obsolete and may be removed
+ * in future releases.
+ */
+ @Deprecated
public static final String ENABLE_BULK_LOAD_TABLE_LIST_KEY =
"exec.enable_bulk_load_table_list";
- public static final BooleanValidator ENABLE_BULK_LOAD_TABLE_LIST = new
BooleanValidator(ENABLE_BULK_LOAD_TABLE_LIST_KEY, null);
/**
- * When getting Hive Table information with exec.enable_bulk_load_table_list
set to true,
- * use the exec.bulk_load_table_list.bulk_size to determine how many tables
to fetch from HiveMetaStore
- * at a time. (The number of tables can get to be quite large.)
+ * See javadoc for {@link ExecConstants#ENABLE_BULK_LOAD_TABLE_LIST_KEY}
*/
+ @Deprecated
+ public static final BooleanValidator ENABLE_BULK_LOAD_TABLE_LIST = new
BooleanValidator(ENABLE_BULK_LOAD_TABLE_LIST_KEY,
+ new OptionDescription("Deprecated after DRILL-7115 improvement."));
+
+ /**
+ * See javadoc for {@link ExecConstants#ENABLE_BULK_LOAD_TABLE_LIST_KEY}
+ */
+ @Deprecated
public static final String BULK_LOAD_TABLE_LIST_BULK_SIZE_KEY =
"exec.bulk_load_table_list.bulk_size";
- public static final PositiveLongValidator BULK_LOAD_TABLE_LIST_BULK_SIZE =
new PositiveLongValidator(BULK_LOAD_TABLE_LIST_BULK_SIZE_KEY,
Integer.MAX_VALUE, null);
+
+ /**
+ * See javadoc for {@link ExecConstants#ENABLE_BULK_LOAD_TABLE_LIST_KEY}
Review comment:
```suggestion
* @see ExecConstants#ENABLE_BULK_LOAD_TABLE_LIST_KEY}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
