kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC
Statement.setMaxRows() with System Option
URL: https://github.com/apache/drill/pull/1714#discussion_r268772086
##########
File path:
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java
##########
@@ -32,4 +33,25 @@
*/
public interface DrillPreparedStatement extends PreparedStatement {
+ /**
+ * @throws SQLException
+ * Any SQL exception
+ */
+ @Override
+ int getMaxRows() throws SQLException;
Review comment:
I think I was declaring it because it seemed Avatica preferred using
`setLargeMaxRows() / getLargeMaxRows()` . I, anyway, cannot really override
this (all calls to `setMaxRows() / getMaxRows()` are redirected to the
`...Large...` methods), so I'll remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
