vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement
JDBC Statement.setMaxRows() with System Option
URL: https://github.com/apache/drill/pull/1714#discussion_r269719305
##########
File path:
exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java
##########
@@ -462,4 +618,25 @@ public void
testParamSettingWhenUnsupportedTypeSaysUnsupported() throws SQLExcep
}
}
+
+ // Sets the SystemMaxRows option
+ private void setSystemMaxRows(int sysValueToSet) throws SQLException {
Review comment:
It looks like a hack to release the lock for one value and acquire for
others. Except adding locks into tests directly, the more clear way may be to
add a boolean flag into method argument whether to acquire or release the lock.
Also, I'm wondering whether these tests which change autoLimit does not
affect other tests, i.e. when one test sets autoLimit to 3, but another test
(which does not contain `setSystemMaxRows()` call, so it is not locked) expects
result with 5 rows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
