ihuzenko commented on issue #1706: DRILL-7115: Improve Hive schema show tables 
performance
URL: https://github.com/apache/drill/pull/1706#issuecomment-479094218
 
 
   @vdiravka , I've addressed comments. 
   
   I totally agree with you that refactoring is better to put into separate 
commits and I'll use this approach in future. 
   
   For show tables authorization improvement was created 
[DRILL-7151](https://issues.apache.org/jira/browse/DRILL-7151) ticket. 
   
   For caches was changed type of ```tableNamesCache``` to  
```LoadingCache<String, Map<String, Schema.TableType>> ```, previously only 
names were cached here, also all work with Guava caches was unified under 
```HiveMetadataCache``` facade. 
   
   For Drill Hive SASL (Kerberos) connection I didn't introduce changes, 
related code from ```DrillHiveMetaStoreClientFactory``` was previously in 
```DrillHiveMetaStoreClient```.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to