KazydubB commented on a change in pull request #1782: DRILL-7237: Fix
single_value aggregate function for variable length types
URL: https://github.com/apache/drill/pull/1782#discussion_r281574189
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestAggregateFunctions.java
##########
@@ -640,11 +644,107 @@ public void testSingleValueFunction() throws Exception {
}
@Test
- public void testSingleValueWithMultipleValuesInput() throws Exception {
+ public void testHashAggSingleValueFunction() throws Exception {
+ List<String> tableNames = Arrays.asList(
+ "cp.`parquet/alltypes_required.parquet`",
+ "cp.`parquet/alltypes_optional.parquet`");
+ for (String tableName : tableNames) {
+ QueryDataBatch result =
Review comment:
It'd be good to move logic from inner `for`-loops (here and below) to
separate private methods, so that the method's body is not that large, what do
you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
