arina-ielchiieva commented on a change in pull request #1810: DRILL-7271: Refactor Metadata interfaces and classes to contain all needed information for the File based Metastore URL: https://github.com/apache/drill/pull/1810#discussion_r296694427
########## File path: metastore/metastore-api/src/main/java/org/apache/drill/metastore/metadata/BaseMetadata.java ########## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.metastore.metadata; + +import org.apache.drill.common.expression.SchemaPath; +import org.apache.drill.exec.record.metadata.ColumnMetadata; +import org.apache.drill.exec.record.metadata.TupleMetadata; +import org.apache.drill.metastore.SchemaPathUtils; +import org.apache.drill.metastore.statistics.ColumnStatistics; +import org.apache.drill.metastore.statistics.StatisticsHolder; +import org.apache.drill.metastore.statistics.StatisticsKind; + +import java.util.Collection; +import java.util.Map; +import java.util.Objects; +import java.util.function.Function; +import java.util.stream.Collectors; + +/** + * Common provider of tuple schema, column metadata, and statistics for table, partition, file or row group. + */ +public abstract class BaseMetadata implements Metadata { + protected final TableInfo tableInfo; + protected final MetadataInfo metadataInfo; + protected final TupleMetadata schema; + protected final Map<SchemaPath, ColumnStatistics> columnsStatistics; + protected final Map<String, StatisticsHolder> statistics; Review comment: What the difference between statistics and column statistics? Maybe statistics should be named better, for example, generalStatistics or metadataStatistics? I think for Metastore we used `metadataStatistics` naming ... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
