vvysotskyi commented on a change in pull request #1810: DRILL-7271: Refactor
Metadata interfaces and classes to contain all needed information for the File
based Metastore
URL: https://github.com/apache/drill/pull/1810#discussion_r296765020
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractGroupScanWithMetadata.java
##########
@@ -572,34 +626,39 @@ public
GroupScanWithMetadataFilterer(AbstractGroupScanWithMetadata source) {
*/
public abstract AbstractGroupScanWithMetadata build();
- public GroupScanWithMetadataFilterer withTable(TableMetadata
tableMetadata) {
+ public B withTable(TableMetadata tableMetadata) {
this.tableMetadata = tableMetadata;
- return this;
+ return self();
Review comment:
`self()` method was introduced to return a specific type of implementation
instead of the base type. So we don't need to add casts for the case when
`this` instance should be returned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
