paul-rogers commented on issue #1829: DRILL-7096: Develop vector for canonical Map<K,V> URL: https://github.com/apache/drill/pull/1829#issuecomment-515719706 This PR has no unit tests. While I am sure that this particular developer got everything 100% correct, I do wonder if future developers might accidentally introduce bugs that will only be caught by users in production. Without unit tests, we are performing without a safety net. Reviews must execute tests in our heads since there is no code to do it for us. I realize that the sponsor probably really wants this code in, and will worry about tests later. But, as an open source project, I do thing it is a good practice to require unit tests for all new and changed code.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
