ihuzenko commented on a change in pull request #1831: DRILL-7331: Drill Iceberg
Metastore metadata expiration
URL: https://github.com/apache/drill/pull/1831#discussion_r309165067
##########
File path:
metastore/iceberg-metastore/src/main/java/org/apache/drill/metastore/iceberg/IcebergMetastore.java
##########
@@ -75,14 +77,15 @@ public IcebergMetastore(DrillConfig config) {
this.tables = new HadoopTables(new Configuration(configuration));
Review comment:
looks like there is no need to pass ```config``` into
```configuration(config)``` , ```baseLocation(config, ...);``` and
```properties(config, ...)``` because it's usage of field set at first line in
constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
