cgivre commented on issue #1841: Drill-7344: Add Geo-IP Functions URL: https://github.com/apache/drill/pull/1841#issuecomment-520892090 Hi Arina, What if we just require that the files are in the classpath, don't ship them with Drill and if the user wants to use these functions, they can put the files in their classpath. Would that work? > On Aug 13, 2019, at 11:46 AM, Arina Ielchiieva <[email protected]> wrote: > > @cgivre <https://github.com/cgivre> taking into account that these files are needed for a couple of functions and their large size, I think we should not allow them into Apache Drill. If these will lead to not adding Geo-IP functions, I think it's much better than enlarging project size. If user needs such functions, he can add them in the classpath. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub <https://github.com/apache/drill/pull/1841?email_source=notifications&email_token=ABKB7PUVY4IZRU4NZIL2X5LQELJMRA5CNFSM4IK5LY7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4GCYOA#issuecomment-520891448>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKB7PSPOSO2BY2E6SUWM3TQELJMRANCNFSM4IK5LY7A>. >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
