arina-ielchiieva commented on a change in pull request #1840: DRILL-7343: Add User-Agent UDFs to Drill URL: https://github.com/apache/drill/pull/1840#discussion_r314356145
########## File path: contrib/udfs/src/main/java/org/apache/drill/exec/udfs/UserAgentFunctions.java ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.drill.exec.udfs; + +import io.netty.buffer.DrillBuf; +import org.apache.drill.exec.expr.DrillSimpleFunc; +import org.apache.drill.exec.expr.annotations.FunctionTemplate; +import org.apache.drill.exec.expr.annotations.Output; +import org.apache.drill.exec.expr.annotations.Param; +import org.apache.drill.exec.expr.annotations.Workspace; +import org.apache.drill.exec.expr.holders.VarCharHolder; +import org.apache.drill.exec.vector.complex.writer.BaseWriter; + +import javax.inject.Inject; + +public class UserAgentFunctions { + + @FunctionTemplate(name = "parse_user_agent", scope = FunctionTemplate.FunctionScope.SIMPLE) + + public static class UserAgentFunction implements DrillSimpleFunc { + @Param + VarCharHolder input; + + @Output + BaseWriter.ComplexWriter outWriter; + + @Inject + DrillBuf outBuffer; + + @Workspace + nl.basjes.parse.useragent.UserAgentAnalyzerDirect uaa; + + public void setup() { + uaa = nl.basjes.parse.useragent.UserAgentAnalyzerDirect.newBuilder().dropTests().hideMatcherLoadStats().build(); + uaa.getAllPossibleFieldNamesSorted(); + } + + public void eval() { + org.apache.drill.exec.vector.complex.writer.BaseWriter.MapWriter queryMapWriter = outWriter.rootAsMap(); + + String userAgentString = org.apache.drill.exec.expr.fn.impl.StringFunctionHelpers.getStringFromVarCharHolder(input); + + if (userAgentString.isEmpty() || userAgentString.equals("null")) { + userAgentString = ""; + } + + nl.basjes.parse.useragent.UserAgent agent = uaa.parse(userAgentString); + + for (String fieldName : agent.getAvailableFieldNamesSorted()) { + + org.apache.drill.exec.expr.holders.VarCharHolder rowHolder = new org.apache.drill.exec.expr.holders.VarCharHolder(); + String field = agent.getValue(fieldName); + + byte[] rowStringBytes = field.getBytes(); + outBuffer.reallocIfNeeded(rowStringBytes.length); + outBuffer.setBytes(0, rowStringBytes); + + rowHolder.start = 0; + rowHolder.end = rowStringBytes.length; + rowHolder.buffer = outBuffer; + + queryMapWriter.varChar(fieldName).write(rowHolder); + } + } + } + + @FunctionTemplate(name = "parse_user_agent", scope = FunctionTemplate.FunctionScope.SIMPLE) + + public static class UserAgentFieldFunction implements DrillSimpleFunc { + @Param + VarCharHolder input; + + @Param + VarCharHolder desiredField; + + @Output + VarCharHolder out; + + @Inject + DrillBuf outBuffer; + + @Workspace + nl.basjes.parse.useragent.UserAgentAnalyzerDirect uaa; + + public void setup() { + uaa = nl.basjes.parse.useragent.UserAgentAnalyzerDirect.newBuilder().dropTests().hideMatcherLoadStats().build(); + uaa.getAllPossibleFieldNamesSorted(); + } + + public void eval() { + String userAgentString = org.apache.drill.exec.expr.fn.impl.StringFunctionHelpers.getStringFromVarCharHolder(input); + String requestedField = org.apache.drill.exec.expr.fn.impl.StringFunctionHelpers.getStringFromVarCharHolder(desiredField); + + if (userAgentString.isEmpty() || userAgentString.equals("null")) { + userAgentString = ""; + } + + nl.basjes.parse.useragent.UserAgent agent = uaa.parse(userAgentString); + String field = agent.getValue(requestedField); Review comment: What behavior if requested field is absent? It returns `Unknown`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
