vvysotskyi commented on a change in pull request #1843: DRILL-7350: Move RowSet
related classes from test folder
URL: https://github.com/apache/drill/pull/1843#discussion_r314432299
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/AbstractRowSet.java
##########
@@ -41,13 +38,19 @@ public AbstractRowSet(VectorContainer container,
TupleMetadata schema) {
}
@Override
- public VectorAccessible vectorAccessible() { return container(); }
+ public VectorAccessible vectorAccessible() {
Review comment:
One-line methods are prevented in a lot of projects. Here is a couple of the
checkstyle rules which forbid such style:
https://checkstyle.sourceforge.io/config_blocks.html#LeftCurly and
https://checkstyle.sourceforge.io/config_blocks.html#RightCurly. I think at
some point, we will update the code to enable these and other rules.
Also, most of IDE can compress displaying such methods automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
