arina-ielchiieva commented on a change in pull request #1843: DRILL-7350: Move RowSet related classes from test folder URL: https://github.com/apache/drill/pull/1843#discussion_r314672905
########## File path: exec/java-exec/src/test/java/org/apache/drill/test/QueryRowSetIterator.java ########## @@ -99,6 +101,13 @@ public DirectRowSet next() { } } + public void printAll() { Review comment: Not sure we should allow printing into stout in the code. When code was for tests, it was ok but since we moved it, I think we should consider passing the stream instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services