vvysotskyi commented on a change in pull request #1860: DRILL-7357: Expose
Drill Metastore data through information_schema
URL: https://github.com/apache/drill/pull/1860#discussion_r329146877
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/Records.java
##########
@@ -503,12 +568,97 @@ public Column(String catalog, String schemaName, String
tableName, RelDataTypeFi
this.COLUMN_SIZE = null;
break;
}
+ this.COLUMN_FORMAT = null;
+ this.NUM_NULLS = null;
+ this.MIN_VAL = null;
+ this.MAX_VAL = null;
+ this.NDV = null;
+ this.EST_NUM_NON_NULLS = null;
+ }
+ public Column(String catalog, String schemaName, String tableName, String
columnName,
Review comment:
Looks like this constructor contains well-refactored code with some logic
similar to the logic in the constructor above. Is it possible to combine these
constructors?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
