arina-ielchiieva commented on a change in pull request #1871: DRILL-7403:
lidate batch checks, vector integretity in unit tests
URL: https://github.com/apache/drill/pull/1871#discussion_r334640711
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/validate/IteratorValidatorBatchIterator.java
##########
@@ -342,8 +342,15 @@ public IterOutcome next() {
}
private void validateBatch() {
- if (validateBatches) {
- new BatchValidator(incoming).validate();
+ if (validateBatches || VALIDATE_VECTORS) {
+ if (! BatchValidator.validate(incoming)) {
+ throw new IllegalStateException(
+ "Batch validation failed. Source operator: " +
+ incoming.getClass().getSimpleName());
+ }
+ // The above seems to validate hash codes, but just calculates
Review comment:
Do we need this comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
