paul-rogers commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336791541
########## File path: contrib/format-esri/README.md ########## @@ -0,0 +1,190 @@ +# Format Plugin for ESRI Shape Files +This format plugin allows Drill to read ESRI Shape files. You can read about the shapefile format here: https://en.wikipedia.org/wiki/Shapefile. + +## Configuration Options +Other than the file extensions, there are no configuration options for this plugin. To use, simply add the following to your configuration: + +``` + "shp": { + "type": "shp", + "extensions": [ + "shp" + ] + } +``` + +## Usage Notes: +This plugin will return the following fields: + +* `gid`: Integer +* `srid`: Integer +* `shapeType`: String +* `name`: Plain text +* `geom`: A geometric point or path. This field is returned as a `VARBINARY`. + +This plugin is best used with the suite of GIS functions in Drill which include the following: + +<h1>Geospatial Functions</h1> Review comment: This seems to be a copy/past of a later file. Any reason to have two copies we maintain in parallel? Can we, instead, reference that other file? Or, are there differences between the two copies? Can't easily tell. If so, can we handle those differently so we don't have to maintain two copies? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
