paul-rogers commented on a change in pull request #1870: DRILL-7359: Add
support for DICT type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r347115016
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/test/rowSet/test/TestRowSet.java
##########
@@ -586,6 +595,490 @@ public void testRepeatedMapStructure() {
RowSetUtilities.verify(expected, actual);
}
+ @Test
+ public void testDictStructure() {
+ final String dictName = "d";
+
+ final TupleMetadata schema = new SchemaBuilder()
+ .add("id", MinorType.INT)
+ .addDict(dictName, MinorType.INT)
+ .value(MinorType.VARCHAR) // required int
+ .resumeSchema()
Review comment:
Nit: perhaps indent the above two lines to show that they form a nested
structure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
