ihuzenko commented on a change in pull request #1899: DRILL-7445: Create batch
copier based on result set framework
URL: https://github.com/apache/drill/pull/1899#discussion_r347379920
##########
File path: exec/vector/src/main/codegen/templates/ColumnAccessors.java
##########
@@ -592,6 +592,32 @@ public final void setDefaultValue(final Object value) {
}
</#if>
}
+
+ @Override
+ public final void copy(ColumnReader from) {
+ ${drillType}ColumnReader source = (${drillType}ColumnReader) from;
+ final DrillBuf sourceBuf = source.buffer();
+ <#-- First cut, copy materialized value.
+ <#if varWidth>
+ byte[] bytes = source.getBytes();
+ setBytes(bytes, bytes.length);
+ <#else>
+ set${label}(source.get${label}());
+ </#if> -->
Review comment:
please remove commented lines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
