paul-rogers commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r349851255
########## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/writers/HDF5IntDataWriter.java ########## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.drill.exec.store.hdf5.writers; + +import ch.systemsx.cisd.hdf5.IHDF5Reader; +import org.apache.drill.common.types.TypeProtos; +import org.apache.drill.exec.physical.resultSet.RowSetLoader; +import org.apache.drill.exec.record.metadata.ColumnMetadata; +import org.apache.drill.exec.record.metadata.MetadataUtils; +import org.apache.drill.exec.store.hdf5.HDF5Utils; +import org.apache.drill.exec.vector.accessor.ScalarWriter; + +import java.util.ArrayList; +import java.util.List; + +public class HDF5IntDataWriter extends HDF5DataWriter { + + private int[] data; + + private List<Integer> listData; + + private ScalarWriter rowWriter; + + // This constructor is used when the data is a 1D column. The column is inferred from the datapath + public HDF5IntDataWriter(IHDF5Reader reader, RowSetLoader columnWriter, String datapath) { + super(reader, columnWriter, datapath); + data = reader.readIntArray(datapath); + listData = new ArrayList<>(); + + for (int datum : data) { + listData.add(datum); + } Review comment: Here we simply copy an array of `int`s into a list of `Integer`s, creating a pile of objects and doing a bunch of work. Can we just use the original `int` array? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
