paul-rogers commented on a change in pull request #1910: DRILL-7393: Revisit
Drill tests to ensure that patching is executed b…
URL: https://github.com/apache/drill/pull/1910#discussion_r352251662
##########
File path: common/src/test/java/org/apache/drill/test/BaseTest.java
##########
@@ -15,24 +15,25 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.drill.exec.expr;
+package org.apache.drill.test;
-import org.apache.drill.BaseTestQuery;
-import org.apache.drill.common.util.TestTools;
-import org.junit.Test;
+import org.apache.drill.common.util.GuavaPatcher;
+import org.apache.drill.common.util.ProtobufPatcher;
-public class TestPrune extends BaseTestQuery {
+public class BaseTest {
Review comment:
The term `BaseTest` is too generic: soon this will contain all manner of
common code. Better solutions are:
* MapRTestBase and HBaseTestBase to patch the code as needed for just those
clients.
* Patchers as a service added to tests where needed, such as is done with
the "dirTestWatcher"
* The patch-on-load approach suggested below.
The approach here is really far too much of a hack to maintain.
Also, this patching means that code running in tests operates in a different
environment than the same code running in production. That will become the
cause of very mysterious bugs.
Can we rethink our approach?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
