vvysotskyi commented on issue #1923: DRILL-7479: Partial fixes for metadata parameterized type issues URL: https://github.com/apache/drill/pull/1923#issuecomment-565235691 @paul-rogers, regarding `FilterExpression.Visitor`, it may seem that generics usage is redundant here, but such design was chosen to make this class extendable as much as possible but with strict API. By design, implementations of this class should be used for specific metastore implementation, so it may be required to provide a storage-specific type for the visitor, as it was done in the existing implementation. Though, there is a single implementation typed with `org.apache.iceberg.expressionsExpression` (non-Drill class), but in the future, it is possible, that other implementations will be added. I worked with the code of `iceberg-metastore` module a lot, and every time I ensured that this is the most thoughtful and stainless part of the metastore work. Regarding changing the serialized metadata format, could you please share some details on how it happens, since I thought that we use only actual types of data that is written to the metastore.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
