arina-ielchiieva commented on a change in pull request #1940: DRILL-7406: Update Calcite to 1.21.0 URL: https://github.com/apache/drill/pull/1940#discussion_r361323935
########## File path: contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcWithMySQLandH2PluginsIT.java ########## @@ -0,0 +1,638 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.store.jdbc; + +import com.wix.mysql.EmbeddedMysql; +import com.wix.mysql.ScriptResolver; +import com.wix.mysql.config.MysqldConfig; +import com.wix.mysql.config.SchemaConfig; +import com.wix.mysql.distribution.Version; +import org.apache.drill.categories.JdbcStorageTest; +import org.apache.drill.common.config.DrillProperties; +import org.apache.drill.exec.ExecConstants; +import org.apache.drill.exec.expr.fn.impl.DateUtility; + +import org.apache.drill.exec.server.DrillbitContext; +import org.apache.drill.exec.store.StoragePluginRegistryImpl; +import org.apache.drill.exec.util.StoragePluginTestUtils; +import org.apache.drill.test.ClusterFixture; +import org.apache.drill.test.ClusterTest; +import org.apache.drill.test.QueryTestUtil; +import org.h2.tools.RunScript; +import org.joda.time.DateTimeZone; +import org.junit.After; +import org.junit.AfterClass; +import org.junit.Assert; +import org.junit.Assume; +import org.junit.BeforeClass; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +import java.io.FileReader; +import java.math.BigDecimal; +import java.net.URL; +import java.nio.file.Paths; +import java.sql.Connection; +import java.sql.DriverManager; + +import static org.hamcrest.CoreMatchers.containsString; +import static org.hamcrest.core.IsNot.not; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertThat; + +/** + * JDBC storage plugin tests against H2 and MySQL data sources. + */ +@Category(JdbcStorageTest.class) +public class TestJdbcWithMySQLandH2PluginsIT extends ClusterTest { + + private static final String TABLE_PATH = "jdbcmulti/"; + private static final String TABLE_NAME = String.format("%s.`%s`", StoragePluginTestUtils.DFS_PLUGIN_NAME, TABLE_PATH); + + private static EmbeddedMysql mysqld; + + @BeforeClass + public static void init() throws Exception { + startCluster(ClusterFixture.builder(dirTestWatcher)); + dirTestWatcher.copyResourceToRoot(Paths.get(TABLE_PATH)); + initH2(); + initMySQL(); + } + + @AfterClass + public static void stopMysql() { + if (mysqld != null) { + mysqld.stop(); + } + } + + @After + public void resetSchema() { + client.resetSession(DrillProperties.SCHEMA); + } + + private static void initH2() throws Exception { + Class.forName("org.h2.Driver"); + String connString = String.format( + "jdbc:h2:%s", dirTestWatcher.getTmpDir().getCanonicalPath()); + + try (Connection connection = DriverManager.getConnection(connString, "root", "root")) { + URL scriptFile = TestJdbcWithMySQLandH2PluginsIT.class.getClassLoader().getResource("h2-test-data.sql"); + Assert.assertNotNull("Script for test tables generation 'h2-test-data.sql' " + + "cannot be found in test resources", scriptFile); + try (FileReader fileReader = new FileReader(scriptFile.getFile())) { + RunScript.execute(connection, fileReader); + } + } + + JdbcStorageConfig jdbcStorageConfig = new JdbcStorageConfig( + "org.h2.Driver", + connString, + "root", + "root", + true); + jdbcStorageConfig.setEnabled(true); + + String pluginName = "h2"; + DrillbitContext context = cluster.drillbit().getContext(); Review comment: Please create method in `ClusterFixture`, for example `definePlugin`, similar to `defineWorkspace` instead. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
