arina-ielchiieva commented on a change in pull request #1941: DRILL-7495: Excel
Reader Not Parsing Dates Correctly in First Column
URL: https://github.com/apache/drill/pull/1941#discussion_r361451017
##########
File path:
contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java
##########
@@ -382,6 +382,26 @@ public void testExplicitSomeQueryWithCompressedFile()
throws Exception {
new RowSetComparison(expected).verifyAndClearAll(results);
}
+ @Test
+ public void testFileWithDoubleDates() throws Exception {
+ String sql = "SELECT `Close Date`, `Type` FROM dfs.`excel/comps.xlsx`
WHERE style='Contemporary'";
Review comment:
If we’ll look at this from the perspective that everybody will start adding
files, this will increase project size.
Generally, we should rather than adding new files:
1. reuse existing files;
2. generate files at runtime, for example for excel files this could have
been done fairly easy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
