cgivre commented on a change in pull request #1778: Drill-7233: Format Plugin for HDF5 URL: https://github.com/apache/drill/pull/1778#discussion_r348182284
########## File path: contrib/format-hdf5/src/main/java/org/apache/drill/exec/store/hdf5/HDF5BatchReader.java ########## @@ -0,0 +1,1210 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.drill.exec.store.hdf5; + +import ch.systemsx.cisd.hdf5.HDF5CompoundMemberInformation; +import ch.systemsx.cisd.hdf5.HDF5DataClass; +import ch.systemsx.cisd.hdf5.HDF5DataSetInformation; +import ch.systemsx.cisd.hdf5.HDF5FactoryProvider; +import ch.systemsx.cisd.hdf5.HDF5LinkInformation; +import ch.systemsx.cisd.hdf5.IHDF5Factory; +import ch.systemsx.cisd.hdf5.IHDF5Reader; +import org.apache.commons.io.IOUtils; +import org.apache.drill.common.config.DrillConfig; +import org.apache.drill.common.exceptions.UserException; +import org.apache.drill.common.types.TypeProtos; +import org.apache.drill.exec.ExecConstants; +import org.apache.drill.exec.expr.holders.BigIntHolder; +import org.apache.drill.exec.physical.impl.scan.file.FileScanFramework.FileSchemaNegotiator; +import org.apache.drill.exec.physical.impl.scan.framework.ManagedReader; +import org.apache.drill.exec.physical.resultSet.ResultSetLoader; +import org.apache.drill.exec.physical.resultSet.RowSetLoader; +import org.apache.drill.exec.record.metadata.ColumnMetadata; +import org.apache.drill.exec.record.metadata.MapBuilder; +import org.apache.drill.exec.record.metadata.MetadataUtils; +import org.apache.drill.exec.record.metadata.SchemaBuilder; +import org.apache.drill.exec.record.metadata.TupleMetadata; +import org.apache.drill.exec.store.hdf5.writers.HDF5DataWriter; +import org.apache.drill.exec.store.hdf5.writers.HDF5DoubleDataWriter; +import org.apache.drill.exec.store.hdf5.writers.HDF5EnumDataWriter; +import org.apache.drill.exec.store.hdf5.writers.HDF5FloatDataWriter; +import org.apache.drill.exec.store.hdf5.writers.HDF5IntDataWriter; +import org.apache.drill.exec.store.hdf5.writers.HDF5LongDataWriter; +import org.apache.drill.exec.store.hdf5.writers.HDF5MapDataWriter; +import org.apache.drill.exec.store.hdf5.writers.HDF5StringDataWriter; +import org.apache.drill.exec.store.hdf5.writers.HDF5TimestampDataWriter; +import org.apache.drill.exec.vector.accessor.ArrayWriter; +import org.apache.drill.exec.vector.accessor.ScalarWriter; +import org.apache.drill.exec.vector.accessor.TupleWriter; + +import org.apache.drill.exec.vector.complex.writer.BaseWriter; +import org.apache.drill.shaded.guava.com.google.common.io.Files; +import org.apache.hadoop.mapred.FileSplit; +import org.joda.time.Instant; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.BufferedReader; +import java.io.File; +import java.io.IOException; +import java.io.InputStream; +import java.io.InputStreamReader; +import java.nio.file.StandardCopyOption; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.BitSet; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +public class HDF5BatchReader implements ManagedReader<FileSchemaNegotiator> { + private static final Logger logger = LoggerFactory.getLogger(HDF5BatchReader.class); + + private static final String PATH_COLUMN_NAME = "path"; + + private static final String DATA_TYPE_COLUMN_NAME = "data_type"; + + private static final String FILE_NAME_COLUMN_NAME = "file_name"; + + private static final String INT_COLUMN_PREFIX = "int_col_"; + + private static final String LONG_COLUMN_PREFIX = "long_col_"; + + private static final String FLOAT_COLUMN_PREFIX = "float_col_"; + + private static final String DOUBLE_COLUMN_PREFIX = "double_col_"; + + private static final String INT_COLUMN_NAME = "int_data"; + + private static final String FLOAT_COLUMN_NAME = "float_data"; + + private static final String DOUBLE_COLUMN_NAME = "double_data"; + + private static final String LONG_COLUMN_NAME = "long_data"; + + private static final String STRING_COLUMN_NAME = "string_data"; + + private static final String BOOLEAN_COLUMN_NAME = "boolean_data"; + + private static final String PATH_PATTERN_REGEX = "/*.*/(.+?)$"; + + private static final Pattern PATH_PATTERN = Pattern.compile(PATH_PATTERN_REGEX); + + private FileSplit split; Review comment: Which fields did you have in mind? I believe all the fields that can be `final` are. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
