arina-ielchiieva commented on a change in pull request #1946: DRILL-7505: PCAP Plugin Fails on IPv6 Packets URL: https://github.com/apache/drill/pull/1946#discussion_r362326297
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/PacketConstants.java ########## @@ -40,7 +40,14 @@ public static final int FRAGMENT_V6 = 44; public static final int AUTHENTICATION_V6 = 51; public static final int ENCAPSULATING_SECURITY_V6 = 50; + public static final int ICMPv6 = 58; public static final int MOBILITY_EXTENSION_V6 = 135; + public static final int HOST_IDENTITY_PROTOCOL = 139; + public static final int SHIM6_PROTOCOL = 140; + + public static final int RESERVED_IPV6_1 = 253; Review comment: Please remove unused constants. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
