paul-rogers commented on a change in pull request #1947: DRILL-7496: Update Dockerfile to publish release images under Apache Docker Hub URL: https://github.com/apache/drill/pull/1947#discussion_r362724806
########## File path: Dockerfile ########## @@ -16,20 +16,28 @@ # limitations under the License. # -FROM centos:7 +# Uses intermediate image for building Drill to reduce target image size +FROM maven:3.6-jdk-8 as build -# Project version defined in pom.xml is passed as an argument -ARG VERSION +# Copy project sources into the container +COPY . /src -# JDK 8 is a pre-requisite to run Drill ; 'which' package is needed for drill-config.sh -RUN yum install -y java-1.8.0-openjdk-devel which ; yum clean all ; rm -rf /var/cache/yum +WORKDIR /src -# The drill tarball is generated upon building the Drill project -COPY target/apache-drill-$VERSION.tar.gz /tmp +# Builds Drill +RUN mvn clean install -DskipTests -q Review comment: Does Dockerhub want to do its own build? In the container? Is the purpose of this to do builds using Docker? Or, to build the "official" Drill container? If the latter, I do think we want to use a release of the software and not rebuild. Else, there is no guarantee that two builds of the container image itself have exactly the same Drill bits. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
