paul-rogers commented on a change in pull request #1892: Drill-7437: Storage Plugin for Generic HTTP REST API URL: https://github.com/apache/drill/pull/1892#discussion_r363137387
########## File path: contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpStoragePluginConfig.java ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.store.http; + +import org.apache.drill.common.map.CaseInsensitiveMap; +import org.apache.drill.common.logical.StoragePluginConfigBase; +import org.apache.drill.shaded.guava.com.google.common.base.Objects; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import com.fasterxml.jackson.annotation.JsonTypeName; + +import java.util.HashMap; +import java.util.Map; +import java.util.Optional; + + +@JsonTypeName(HttpStoragePluginConfig.NAME) +public class HttpStoragePluginConfig extends StoragePluginConfigBase { + private static final Logger logger = LoggerFactory.getLogger(HttpStoragePluginConfig.class); + + public static final String NAME = "http"; + + public final Map<String, HttpAPIConfig> connections; Review comment: The idea here is to have one HTTP plugin config with multiple connections. I wonder if this is useful in practice? When would I create a new connection and when a new plugin config? Might it make sense for each plugin config to correspond to one HTTP service? Flatten the `HttpAPIConfig` properties here. Then, in my query, rather than saying: ``` SELECT * FROM http.google.foo; SELECT * FROM http.facebook.bar; ``` I might say: ``` SELECT * FROM googleRest.foo; SELECT * FROM facebookRest.bar; ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
