[GitHub] [drill] cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin for Generic HTTP REST API

[GitBox]

cgivre commented on a change in pull request #1892: DRILL-7437: Storage Plugin 
for Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r365625474
 
 

 ##########
 File path: 
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/HttpStoragePluginConfig.java
 ##########
 @@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.http;
+
+import org.apache.drill.common.map.CaseInsensitiveMap;
+import org.apache.drill.common.logical.StoragePluginConfigBase;
+import org.apache.drill.shaded.guava.com.google.common.base.Objects;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonTypeName;
+
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Optional;
+
+
+@JsonTypeName(HttpStoragePluginConfig.NAME)
+public class HttpStoragePluginConfig extends StoragePluginConfigBase {
+  private static final Logger logger = 
LoggerFactory.getLogger(HttpStoragePluginConfig.class);
+
+  public static final String NAME = "http";
+
+  public final Map<String, HttpAPIConfig> connections;
 
 Review comment:
   @paul-rogers 
   I sent a note to the email alias about this.  Here is how I envisioned this 
being used: a user could create two instances of this plugin, one called 
`FaceSpace` and the other called `CatTube`.  Within in each, they could define 
the various APIs within that space.  So for instance, they could have:
   ```sql
   SELECT *
   FROM `cattube`.`kittens`.`?param1=foo&param2=bar`
   ```
   and
   ```sql
   SELECT * 
   FROM `CatTube`.`cuteCats`.`?param1=foo&param2=bar`
   ```
   Alternatively, they could group them all into one instance, and give the 
connections names like `CatTube_cuteKittens` etc.
   
   The parameters make up the `table` portion of the query.  Of course static 
parameters can be passed in the config as well as in post bodies etc, all in 
the config. 
   
   Does that make sense?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services