cgivre commented on a change in pull request #1778: DRILL-7233: Format Plugin
for HDF5
URL: https://github.com/apache/drill/pull/1778#discussion_r365817001
##########
File path:
contrib/format-hdf5/src/test/java/org/apache/drill/exec/store/hdf5/TestHDF5Format.java
##########
@@ -863,14 +863,14 @@ public void testCompoundExplicitQuery2() throws
Exception {
@Test
public void testSerDe() throws Exception {
- String sql = "SELECT COUNT(*) FROM cp.`hdf5/dset.h5`";
+ String sql = "SELECT COUNT(*) FROM dfs.`hdf5/dset.h5`";
String plan = queryBuilder().sql(sql).explainJson();
long cnt = queryBuilder().physical(plan).singletonLong();
assertEquals("Counts should match",1L, cnt);
}
@Test
- public void testExplicitQueryWithCompressedFile() throws RpcException,
IOException {
+ public void testExplicitQueryWithCompressedFile() throws Exception,
IOException {
Review comment:
Sorry about that. I missed that one. I added Javadoc to the
`generateCompressedFile()` function as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
